Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing second to minute conversion as selected unit is in second #2420

Merged
merged 8 commits into from
Jul 2, 2021

Conversation

samikroy
Copy link
Contributor

@samikroy samikroy commented Jun 7, 2021

Fixes #

Removing second to minute conversion as selected unit is in second

Removed second to minute conversion as the unit is set to 24, which indicates seconds.
Removing second to minute conversion (/60) as selected unit is second (unit : 24)
Workbooks/WorkspaceUsage.json Outdated Show resolved Hide resolved
@v-ampami
Copy link
Contributor

v-ampami commented Jun 8, 2021

Please update the workbook version in workbook metadata json.

@v-ampami
Copy link
Contributor

There are still locales in documentation links. Please remove all the locale("en-us", "en-gb") from documentation links.

@v-rucdu
Copy link
Contributor

v-rucdu commented Jun 15, 2021

@samikroy : Could you please resolve the merge conflicts.

Thanks!!!

@samikroy
Copy link
Contributor Author

samikroy commented Jun 16, 2021

@samikroy : Could you please resolve the merge conflicts.

Thanks!!!

Done, thank you.

@liatlishams - could you please help in merging.

Copy link
Contributor Author

@samikroy samikroy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated as commented.

@samikroy
Copy link
Contributor Author

@v-ampami , @liatlishams , @Amitbergman - Request your help to approve the workbook.

@v-jayakal v-jayakal merged commit 30a30db into Azure:master Jul 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants